Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New signature for Aqara roller shade driver E1 #1803

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

javicalle
Copy link
Collaborator

@javicalle javicalle commented Oct 3, 2022

New device signature for the Aqara roller shade driver E1.
The new quirk extends the existing RollerE1AQ and just overwrite the signature.

Fix: #1801

New device signature for the Aqara roller shade driver E1.
The new quirk extends the existing `RollerE1AQ` and just overwrite the signature.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3175216560

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 71.561%

Totals Coverage Status
Change from base Build 3174129000: 0.008%
Covered Lines: 5312
Relevant Lines: 7423

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Base: 71.55% // Head: 71.56% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ca77c60) compared to base (d40f0d3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1803   +/-   ##
=======================================
  Coverage   71.55%   71.56%           
=======================================
  Files         239      239           
  Lines        7421     7423    +2     
=======================================
+ Hits         5310     5312    +2     
  Misses       2111     2111           
Impacted Files Coverage Δ
zhaquirks/xiaomi/aqara/roller_curtain_e1.py 60.86% <100.00%> (+1.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmulcahey dmulcahey merged commit d40a532 into zigpy:dev Oct 3, 2022
@javicalle javicalle deleted the patch-4 branch October 3, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AQARA Roller Shutter ZHAQuirk not recognised
4 participants